Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LifterLMS streamline mode and the /membership/ CPT slug #2927

Merged

Conversation

MaximilianoRicoTabo
Copy link
Contributor

  • Unregister the CPT that resevers the 'memberships' slug.

All Submissions:

Changes proposed in this Pull Request:

Unregister llms_membership if streamline version of lifterlms is enabled.

Resolves #2820

How to test the changes in this Pull Request:

  1. Create a page with 'memberships' slug
  2. Check that it doesn't render appropriately
  3. Apply this patch.
  4. Flush cache saving permalinks.
  5. Check again.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

 * Unregister the CPT that resevers the 'memberships' slug.
@dparker1005 dparker1005 added this to the 3.1 milestone Jun 4, 2024
@ideadude
Copy link
Member

Instead of hooking into register_post_types and maybe adding the filter, we could just hook into register_post_type_args and put the streamline check into THAT callback function.

 * Hook directly into the register_post_type_args filter.
@MaximilianoRicoTabo
Copy link
Contributor Author

Added suggested change. Tested at local, works perfect. Thanks @ideadude

@dparker1005 dparker1005 changed the base branch from dev to v3.1 June 17, 2024 15:37
@dparker1005 dparker1005 merged commit 93d5734 into strangerstudios:v3.1 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LifterLMS streamline mode and the /membership/ CPT slug
3 participants