Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing potentially ambiguous properties in get_orders() #2929

Merged

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

When both id and discount_code_id are used, the id column in the database is ambiguous.

This change defines the table for all search properties in get_orders().

Resolves XXX.

How to test the changes in this Pull Request:

$order_args = array(
'id' => '82',
'discount_code_id' => '2',
);
var_dump( MemberOrder::get_orders( $order_args ) );

Returns empty array before the fix, even if there is a matching order. After the fix, returns matching orders.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@ideadude ideadude merged commit 5ef0ba3 into strangerstudios:dev Apr 10, 2024
@dparker1005 dparker1005 deleted the get_orders_ambiguous_property branch April 11, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants