Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding level group information to site health #2931

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Adding level group information to site health.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Copy link
Member

@kimcoleman kimcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. I wonder if we should merge the levels and level groups in Site Health. Is it easier to paste as a giant JSON into a formatter and see the level groups with levels within? I'm open to this as-is or switching it up. Do we use this formatted membershiplevels data any other way?

@dparker1005
Copy link
Member Author

I'd be open to merging level groups and levels, though I'm not sure how many "levels of nesting" is too many for a single site health option. It would look better in a JSON formatter, but is more difficult to read "on the fly". I can go either way on it, and we can always change the choice down the line. Site Health is mainly for our support's use anyways

@ideadude ideadude merged commit 0ac52eb into strangerstudios:dev Apr 10, 2024
@dparker1005 dparker1005 deleted the site-heath-level-groups branch April 11, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants