Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMProEmail class attributes created dynamically throw deprecated warn… #2934

Merged

Conversation

MaximilianoRicoTabo
Copy link
Contributor

…ings in PHP 8.2

  • Declare $headers and $attachments as class attributes.

All Submissions:

Changes proposed in this Pull Request:

Resolves #2881

How to test the changes in this Pull Request:

  1. Switch PHP to 8.2 and enable wp_debug to true.
  2. Try cancelling a membership without this patch and see the warning
  3. Apply this patch and repeat steps above. Warning should have gone.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

…ings in PHP 8.2

 * Declare $headers and $attachments as class attributes.
@ideadude ideadude merged commit 2acc68c into strangerstudios:dev Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depricated warngins - PHP 8.2
4 participants