Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMPro_Discount_Code class attributes created dynamically throw deprec… #2936

Conversation

MaximilianoRicoTabo
Copy link
Contributor

…ated warnings in PHP 8.2

Declare dynamic created props as class attributes.

Screenshot 2024-04-04 at 3 16 22 PM

All Submissions:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

…ated warnings in PHP 8.2

 Declare dynamic created props as class attributes.
@dparker1005
Copy link
Member

Looks good! Though I noticed setting the $code property is missing in get_discount_code_by_code(). Can we declare the $code property in this PR and squeeze setting it into that get_discount_code_by_code() function?

@ideadude ideadude merged commit 914bc6c into strangerstudios:dev Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants