Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to "View: My Access" #2938

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Default to "View: My Access" #2938

merged 3 commits into from
Apr 10, 2024

Conversation

andrewlimaza
Copy link
Contributor

  • ENHANCEMENT: Default to "View with my access" when no option is found. Fixes an issue where defaulting to View with access would confuse admins and not highlight the code green as the CSS class is missing.

All Submissions:

@andrewlimaza
Default to "View: My Acccess"
d662a98 
* ENHANCEMENT: Default to "View with my access" when no option is found. Fixes an issue where defaulting to View with access would confuse admins and not highlight the code green as the CSS class is missing.
@dparker1005
Copy link
Member

Just added some quick changes to enforce "if the setting is not yes or no, default to current" logic in case the value somehow gets set to something else

@ideadude ideadude merged commit 8c6bfb5 into strangerstudios:dev Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dparker1005 dparker1005 dparker1005 approved these changes

Assignees
No one assigned
Labels
Blocking Next Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewlimaza @dparker1005 @ideadude