Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging print.css into frontend.css #2940

Merged
merged 1 commit into from
May 13, 2024

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Consolidating print.css into frontend.css.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Copy link
Member

@kimcoleman kimcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that there is very little concern someone made a local print.css file - but since it is "possible" we have backwards incompatible changes, would this force this to be 3.1? I'm good with either case. I have very little confidence anyone has a custom location print.css since it was just one line.

@dparker1005 dparker1005 added this to the 3.1 milestone Apr 10, 2024
@kimcoleman kimcoleman merged commit fd48f8c into strangerstudios:dev May 13, 2024
@dparker1005 dparker1005 deleted the remove-printcss branch May 20, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants