Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing HTML tags from localized text #2941

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Alternative to #1994.

Updates "discount code applied" strings to all be the same and to have the <strong> tags outside of the localized string.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

pages/checkout.php Outdated Show resolved Hide resolved
Copy link
Member

@kimcoleman kimcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as is for codes applied during the checkout / on checkout page. When you pass a code via the URL I am getting numbers output at the end of the string. sprintf fixes, but I don't know if that's the right choice or there's another fix. Test with a url-applied code and see.

Co-authored-by: Kim Coleman <[email protected]>
@dparker1005
Copy link
Member Author

sprintf() is the correct choice, good catch!

@ideadude ideadude merged commit a2a5f12 into strangerstudios:dev Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants