Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support users without a role #2942

Merged

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

WordPress allows users to not have a role. In our Edit Member page, we don't support that option, so we default to the first value. This default could be a "powerful", like Membership Manager. If the page is then saved, the user will actually be given that role.

The fix is to have an option for "no role" and this PR is based on the core WP Edit User code here:
https://github.com/WordPress/wordpress-develop/blob/13fd2f829b01156174d1ca7ca2236eb9c7248e42/src/wp-admin/user-edit.php#L453-L461

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@ideadude ideadude merged commit 0852613 into strangerstudios:dev Apr 10, 2024
@dparker1005 dparker1005 deleted the edit-member-support-no-role branch April 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants