Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show login errors when logged in successfully #2949

Merged

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Makes sure that "log in errors" aren't shown when a user is successfully logged in.

Resolves XXX.

How to test the changes in this Pull Request:

Couldn't replicate, but here were the reported steps.

  1. Go to your frontend login page
  2. Enter a username but no pw, submit form
  3. Shows error message Error: The password field is empty.
  4. add your PW, submit form.
  5. you get logged in, but error message still showing.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@ideadude ideadude merged commit 35eb5f9 into strangerstudios:dev Apr 10, 2024
@dparker1005 dparker1005 deleted the login-errors-when-logged-in branch April 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants