-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View With selector in admin bar not working as expected in Firefox we… #2953
View With selector in admin bar not working as expected in Firefox we… #2953
Conversation
…b browser. * Catch Mouseout event from select#pmpro-admin-membership-access and stop propagation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this fix on the 2024 theme. When loading the front page, the issue still occurs and I get this error in the console referencing the code added in this PR:
Uncaught ReferenceError: jQuery is not defined
We would either need to ensure that jQuery is loaded here or make this change with vanilla JS
I can't reproduce what you mention @dparker1005 . Also it doesn't make sense to me. jQuery is loaded by WP core, it shouldn't affect which theme we're using. |
Reproduced and updated. Please disregard comment above. |
ChatGPT likes this vanilla JS solution which will avoid the jQuery conflict: @MaximilianoRicoTabo Can you test this and update the PR if it works? |
…b browser.
All Submissions:
Changes proposed in this Pull Request:
Catch Mouseout event from select#pmpro-admin-membership-access and stop propagation
Resolves #2907 .
How to test the changes in this Pull Request:
Follow steps from the issue to reproduce it. Apply the patch to check it doesn't any more.
Other information:
Changelog entry