Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some code issues in 3.0 #2955

Merged

Conversation

mircobabini
Copy link
Member

@mircobabini mircobabini commented Apr 12, 2024

All Submissions:

Changes proposed in this Pull Request:

The approach was to scan for errors using PhpStorm. Then:

  • Fixed some variable names that changed after a refactoring
  • Removed some duplicate array keys
  • Fixed some "undefined variable"
  • Some other minor fixes
  • Fixed missing color var references

Nothing of this should be affecting the usage. I'm just removing some red marks in the code editors.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@dparker1005 dparker1005 merged commit cdb2380 into strangerstudios:dev Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants