Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe/PPE: Ensure the credentials are set on each gateway before performing API requests #2956

Conversation

mircobabini
Copy link
Member

…request

All Submissions:

Changes proposed in this Pull Request:

Running the migration tool from 3.0 for the subs table makes a large number of requests.
Many of them can be avoided if you still have orders for a disabled gateway w/o the credentials set.

This was already implemented for some gateway.
The support is extended to Stripe (checking the secret key only) and to PPE (checking user/pass/signature keys).

How to test the changes in this Pull Request:

  1. Open an errored subscription, which has a message from the gateway after trying to connect w/o credentials
  2. Apply this patch and update the subscription
  3. The error will now be the message from this patch; this means no API request has been made bc there are no credentials set.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@dparker1005 dparker1005 merged commit d1ce248 into strangerstudios:dev Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants