Removing role from Edit Member page #2961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
We have seen issues on websites where users could have multiple roles or a role that doesn't show in the Roles list on the PMPro Edit Member page. In these situations, saving the Edit Member page for a user could unintentionally change the user's role on the website, potentially adding or removing capabilities for that user. Either of these situations is dangerous and should be avoided.
In the medium term, we would like to add the Role option back, but this needs to be done to ensure compatibility with the various Role setups and plugins available in WordPress. As a "quick fix", this PR removes the role setting entirely. Admins can still edit roles for users from the default Edit User page in core WP.
Other information:
Changelog entry