Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing role from Edit Member page #2961

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

We have seen issues on websites where users could have multiple roles or a role that doesn't show in the Roles list on the PMPro Edit Member page. In these situations, saving the Edit Member page for a user could unintentionally change the user's role on the website, potentially adding or removing capabilities for that user. Either of these situations is dangerous and should be avoided.

In the medium term, we would like to add the Role option back, but this needs to be done to ensure compatibility with the various Role setups and plugins available in WordPress. As a "quick fix", this PR removes the role setting entirely. Admins can still edit roles for users from the default Edit User page in core WP.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005 dparker1005 merged commit 5a6f709 into strangerstudios:dev Apr 18, 2024
@dparker1005 dparker1005 deleted the edit-member-remove-role branch April 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant