Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Gateway" on Member Edit #2970

Merged

Conversation

andrewlimaza
Copy link
Contributor

@andrewlimaza andrewlimaza commented Apr 22, 2024

  • ENHANCEMENT: Show the payment gateway on the member edit orders panel to make it easier to differentiate where the payments are coming from when using more than one gateway.

Resolves: #2958

All Submissions:

How to test the changes in this Pull Request:

  1. Navigate to the Member Edit Screen and choose "Orders"
  2. See the gateway name included in the table.

Screenshot 2024-04-22 at 11 27 09

* ENHANCEMENT: Show the payment gateway on the member edit orders panel to make it easier to differentiate where the payments are coming from when using more than one gateway.

Resolves: strangerstudios#2958
Copy link
Member

@dparker1005 dparker1005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that showing the gateway here would be nice. We probably want this change in the Subscriptions tab as well, along with including the Subscription Transaction ID there.

Long-term, it would be nice to have a system for showing/hiding individual columns similar to the "Screen Options" dropdown on List Tables

@andrewlimaza
Copy link
Contributor Author

Thanks @dparker1005 I have committed those changes, good catch. I'll do a PR shortly for Subscriptions tab (in a separate PR)

Copy link
Member

@kimcoleman kimcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this - we should be cautious since there is less horizontal space on this panel and also since admins cannot change visible columns. We can tackle some way to have columns hidden or shown if we feel this gets to a place where there are too many columns. For now, we have the space and nothing is wrapping too much even on my Macbook.

@dparker1005 dparker1005 merged commit 0972f9e into strangerstudios:dev May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Show payment gateway on the Subscriptions and Orders tabs of the Member Edit page.
3 participants