Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing warnings on User Fields settings page #2975

Merged

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

pmpro_get_field_html() and pmpro_get_field_group_html() echo their contents immediately. Those functions do not return their contents.

This PR fixes warnings with code that expects the contents to be returned instead of already being echoed.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Copy link
Contributor

@andrewlimaza andrewlimaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Making an internal note that we do escape and sanitize within those callbacks already.

@dparker1005 dparker1005 merged commit 8ae94fe into strangerstudios:dev May 8, 2024
@dparker1005 dparker1005 deleted the kses-null-fix-user-fields branch May 8, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants