Add Group ID to Level Settings page #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ENHANCEMENT: Added group ID value to the menu location.
dparker1005
reviewed
Apr 26, 2024
adminpages/membershiplevels.php
Outdated
| @@ -342,7 +342,7 @@ function update_level_group_order(event, ui) { | |||
| <button class="pmpro_section-toggle-button" type="button" aria-expanded="<?php echo $section_visibility === 'hidden' ? 'false' : 'true'; ?>"> | |||
| <span class="dashicons dashicons-arrow-<?php echo $section_visibility === 'hidden' ? 'down' : 'up'; ?>-alt2"></span> | |||
| <input type="hidden" class="pmpro-level-settings-group-id" value="<?php echo esc_attr( $level_group->id ); ?>" /> | |||
| <?php echo esc_html( $level_group->name ) ?> | |||
| <?php echo esc_html( $level_group->name ) . '<small>'. sprintf( esc_html( 'ID: %d', 'paid-memberships-pro' ), $level_group->id ) . '</small>'; ?> | |||
There was a problem hiding this comment.
Suggested change
| <?php echo esc_html( $level_group->name ) . '<small>'. sprintf( esc_html( 'ID: %d', 'paid-memberships-pro' ), $level_group->id ) . '</small>'; ?> | |
| <?php echo esc_html( $level_group->name ) . '<small>'. esc_html( sprintf( __( 'ID: %d', 'paid-memberships-pro' ), $level_group->id ) ) . '</small>'; ?> |
Localizing the ID string and making sure that PHPCS doesn't complain about non-escaped strings.
There was a problem hiding this comment.
Thanks for catching that, I made it translatable by changing esc_html to esc_html__
dparker1005
approved these changes
Apr 26, 2024
kimcoleman
approved these changes
May 7, 2024
dparker1005
requested changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of putting this to the right of the name is to try and not clutter up the group names and make it easily visible without clicking around to get this data.
Screenshots
All Submissions: