Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit customer in Stripe button is present in Edit Member page despite… #2987

Conversation

MaximilianoRicoTabo
Copy link
Contributor

… the active subscription belongs to a different gateway.

  • Check if there's an active Stripe subscription before render the button
Screenshot 2024-05-13 at 3 20 59 PM Screenshot 2024-05-13 at 3 19 34 PM

All Submissions:

Changes proposed in this Pull Request:

Check if there's an active Stripe subscription before render the button

Resolves #2986

How to test the changes in this Pull Request:

Follow steps from the linked issue.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

… the active subscription belongs to a different gateway.

 * Check if there's an active Stripe subscription before render the button
@dparker1005
Copy link
Member

Is it still helpful to show a link to the customer in Stripe even if they don't have an active subscription? For example, if we want to look at their old subscriptions in Stripe for some reason?

@kimcoleman
Copy link
Member

I could go either way on this but my gut says if they do not have an active Stripe subscription, do not show it. It could imply that there is an active connection there that isn't.

An alternative is to add the Edit Customer in Stripe button on the single Subscription admin view. This would then be present for active subs as well as cancelled.

Copy link
Member

@ideadude ideadude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to make this code clearer if we decide to do this.

@ideadude
Copy link
Member

ideadude commented Jun 11, 2024

So tough.

It's a good idea to have a button on the individual subscription pages that links to those subscriptions in Stripe.

For the main "Edit customer in Stripe" button, we could move this to the user info tab and put it next to Edit User button. If we move it there, we should show it if there is a customer, even if there are no subs or active subs at Stripe.

We should also make the text title case in the button IMO.

@dparker1005 dparker1005 added this to the 3.1 milestone Jun 11, 2024
@dparker1005
Copy link
Member

I just applied the recent suggestions from @ideadude.

@MaximilianoRicoTabo @kimcoleman Can you both give this new version a quick look to make sure that you don't see any issues?

@MaximilianoRicoTabo
Copy link
Contributor Author

image

@kimcoleman kimcoleman removed the request for review from dparker1005 June 27, 2024 22:49
@kimcoleman kimcoleman merged commit 230e18f into strangerstudios:dev Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants