Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the accepted credit cards option and select field on billing forms. Deprecating the filter: pmpro_include_cardtype_field #2989

Merged

Conversation

kimcoleman
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

This PR removes the option and display of "We accept {card types}" from billing format.

The option was not actually validating whether an "accepted" card was used. We do not need to show this on the frontend billing forms.

This PR also removes the filter to optionally include a dropdown for "card type" on billing fields. We will now always have card type get set as a hidden field using JavaScript and the credit card validator. We might want to adjust this so it isn't even a hidden field at checkout and is rather just handled when orders are saved. I'm open to talking through that.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

  • DEPRECATED: No longer storing an option for accepted card types or allowing a card type select field in payment forms.
  • DEPRECATED: Deprecated the filter pmpro_include_cardtype_field.

… forms. Deprecating the filter: `pmpro_include_cardtype_field`
@kimcoleman kimcoleman changed the base branch from dev to v3.1 May 14, 2024 14:22
@kimcoleman
Copy link
Member Author

TO DO: I think we also need to remove the default setting in upgrade_1.php to set card types. https://github.com/strangerstudios/paid-memberships-pro/blob/dev/includes/updates/upgrade_1.php#L22-L23

@dparker1005 dparker1005 added this to the 3.1 milestone Jun 4, 2024
@kimcoleman
Copy link
Member Author

@dparker1005 fixed merge conflicts here.

@dparker1005 dparker1005 merged commit 3d0a0c2 into strangerstudios:v3.1 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants