Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/frontend UI ux cycle #3003

Merged
merged 24 commits into from
Jun 12, 2024
Merged

Feature/frontend UI ux cycle #3003

merged 24 commits into from
Jun 12, 2024

Conversation

kimcoleman
Copy link
Member

@kimcoleman kimcoleman commented Jun 4, 2024

All Submissions:

Changes proposed in this Pull Request:

Keeping this a draft PR to see how the merge will go. This will help me see what the old selectors were so I can build a mega function using the pmpro_element_class filter to "bridge fix" old sites with heavy custom styles.

How to test the changes in this Pull Request:

I'm going to set up a dev for our team to use that has various WP themes and a theme switcher installed so we can preview the changes.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

  • FEATURE: Added two style variations and three color settings to style the frontend pages.
  • FEATURE: Now offering a smartly generated non-member/no-access message option in addition to the custom.
  • ENHANCEMENT: Now offering a way to disable all unnecessary design layer styles and load base required CSS only.
  • BUG FIX: Removed unused image files.
  • BUG FIX: Removed unused Google charts JavaScript file.
    apply_filters_deprecated( 'pmprorh_user_table_fields', array( array( 'user_url' ) ), 'TBD', 'pmpro_user_table_fields' );
  • ENHANCEMENT: Added filter pmpro_user_table_fields filter that is meant to replace the pmprorh_user_table_fields filter. The old filter is still applied if in place, but will be deprecated eventually.
  • ENHANCEMENT: Added filter pmpro_field_repair_non_associative_options filter that is meant to replace the pmprorh_repair_non_associative_options filter. The old filter is still applied if in place, but will be deprecated eventually.
  • ENHANCEMENT: Added filter pmpro_field_show_required_on_profile filter that is meant to replace the pmprorh_show_required_on_profile filter. The old filter is still applied if in place, but will be deprecated eventually.
  • ENHANCEMENT: Added filter pmpro_field_get_html filter that is meant to replace the pmprorh_get_html filter. The old filter is still applied if in place, but will be deprecated eventually.
  • ENHANCEMENT: Standardizing CSS selectors to make theming a PMPro site more straightforward. We will custom code that leverages the pmpro_element_class filter to put back old selectors as we see a need.
  • BUG FIX/ENHANCEMENT: Removed unused function pmpro_getClassForField().
  • DEPRECATED: Removed the ability to customize no access messages for the RSS feed and the secondary option for logged out members. Use the filters in place of these to customize.

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005 dparker1005 added this to the 3.1 milestone Jun 4, 2024
@kimcoleman kimcoleman marked this pull request as ready for review June 9, 2024 17:01
@dparker1005 dparker1005 merged commit 9b3ae05 into v3.1 Jun 12, 2024
@dparker1005 dparker1005 deleted the feature/frontend-ui-ux-cycle branch July 5, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants