Adding filters for formatted order total, subtotal, tax

[dparker1005]

All Submissions:

• Have you followed the Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Adds the following filters to adjust how an order's total, subtotal, and tax values are displayed across PMPro:

• pmpro_order_formatted_total
• pmpro_order_formatted_subtotal
• pmpro_order_formatted_tax

Opened as an alternative to #2988

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

[louiswol94]

@dparker1005 this is great!

[louiswol94]

Hey @dparker1005

I found one instance so far where we also need to filter.

$subscription->get_cost_text()

WDYT?

[louiswol94]

I think if we can add a filter for get_cost_text() then we will be getting really close to a full integration 😄
BTW, I am loving the UI updates you guys have been making!

[louiswol94]

@dparker1005 Sorry for all the messages.

It looks like this PR caused an error on one specific page. /adminpages/member-edit/pmpro-class-member-edit-panel-orders.php

The orders on this page are just results from the DB and not Order objects as such.

[louiswol94]

Hey @dparker1005

I found one instance so far where we also need to filter.

$subscription->get_cost_text()

WDYT?

https://github.com/strangerstudios/paid-memberships-pro/pull/3018/files

[dparker1005]

Hi @louiswol94, thank you for the feedback!

I have opened #3020 to address the fatal error and #3021 to add the pmpro_subscription_cost_text filter. Please feel free to review those and let us know if you have any additional feedback

[louiswol94]

Thanks @dparker1005 , you are very quick!

Regarding the cost text filter, you will see in my PR I added a getter for membership_level_id, we need to at least be able to access the Level ID in the callback function for my scenario.

With your current filter, it does not really help much AFAIU, because all the subscription data is protected.

Wdyt?

[dparker1005]

Hi @louiswol94,

You should be able to call $subscription->get_membership_level_id() without it being explicitly defined in the PMPro_Subscription class as a result of the magic __call() method. If that is not working, can you please link me to the code that you are using and I can take a closer look?

[louiswol94]

Hi @louiswol94,

You should be able to call $subscription->get_membership_level_id() without it being explicitly defined in the PMPro_Subscription class as a result of the magic __call() method. If that is not working, can you please link me to the code that you are using and I can take a closer look?

@dparker1005 Ah I missed that, thanks! Seems to be working :)

Do you guys have an ETA for the 3.1 release?

[dparker1005]

I am glad to hear that method is now working!

We do not typically speculate on release dates for our plugins as release schedules depend on a number of uncontrollable variables including the time required to confidently test all of the merged changes on different site setups.