Fix a small content warning when trying to add the CSS body class dynamically. #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BUG FIX: Fixed an issue in some cases where a warning would be shown when trying to dynamically add the membership level body CSS class. NOTE: I cannot replicate this but I assume there is some sort of missing data/stray data in the database that's adding to the array. A customer was facing this issue on a specific page on their site. The array would be `[1] => NULL` on dumping.
dparker1005
reviewed
Jun 19, 2024
There was a problem hiding this comment.
In my tests, $post_levels[1] looks to be an array of IDs and $post_level is just a level ID as a string. Therefore referencing $post_level[0] doesn't really make sense.
Maybe the solution here is to just rename the variable $post_level to be $post_level_id for clarity, and then to switch $classes[] = 'pmpro-body-level-' . $post_level[0]; to $classes[] = 'pmpro-body-level-' . $post_level_id;.
|
@andrewlimaza I just want to confirm, do you have any concerns about this new fix? |
|
This does fix the warning, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I cannot replicate this but I assume there is some sort of missing data/stray data in the database that's adding to the array. A customer was facing this issue on a specific page on their site.
All Submissions: