Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building our own PayPal button that can be translated and is accessible. #3026

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

kimcoleman
Copy link
Member

@kimcoleman kimcoleman commented Jun 27, 2024

All Submissions:

Changes proposed in this Pull Request:

Based on this older PR (#2074), I believe a better approach is to now just build this PayPal button ourselves. This way, it can be translated and is also more accessible.

We should consider this PR and close the other.

Examples of the button on 3.1 branch with both design options:

Screenshot 2024-06-27 at 6 29 28 PM

Screenshot 2024-06-27 at 6 29 19 PM

This PR also deprecates the pmpro_paypal_button_image filter.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@dparker1005
Copy link
Member

Just a note, our Add PayPal Express Add On should be updated to use the new button. I've opened an Issue in that repository to track this enhancement request.

@dparker1005 dparker1005 merged commit 0154ec5 into strangerstudios:v3.1 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants