Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/overhaul email templates #3032

Merged
merged 22 commits into from
Jul 2, 2024
Merged

Enhancement/overhaul email templates #3032

merged 22 commits into from
Jul 2, 2024

Conversation

MaximilianoRicoTabo
Copy link
Contributor

@MaximilianoRicoTabo MaximilianoRicoTabo commented Jun 28, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Resolves XXX.

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@MaximilianoRicoTabo
Overhaul and reevaluate emails in core PMPro
3e30447 
 * Remove trial_ending (this is deprecated)
@MaximilianoRicoTabo
Overhaul and reevaluate emails in core PMPro
45daf48 
* Remove checkout_express and checkout_express_admin (the regular paid emails are fine for this)
@MaximilianoRicoTabo
Overhaul and reevaluate emails in core PMPro
080de48 
 * Remove checkout_freetrial, checkout_trial, checkout_freetrial_admin, checkout_trial_admin (the regular free or paid emails are the same, these are not needed).
@MaximilianoRicoTabo
Overhaul and reevaluate emails in core PMPro
fc6648a 
* make sendBillableInvoiceEmail deprecated
* call sendInvoiceEmail instead
@MaximilianoRicoTabo
* With MMPU in core, could the Billing Failure email be smarter - spe…
b21f073 
…cific to the level that failed and include the correct link to the membership billing page
@MaximilianoRicoTabo
Check if gateway object supports payment_method_updates in order to s…
b0e5f46 
…how update billing info link, otherwise just show account page.
@MaximilianoRicoTabo
* Revamp pmpro_email_templates_defaults.
ae83085 
* Remove header and footer from default pmpro_email_templates_defaults
* Rename some default description as needed
@MaximilianoRicoTabo
* Add more WPCS
07a4335 
* Bring footer and header directly to the email
@MaximilianoRicoTabo
* Change name of cancel on next payment date emails.
1ac07f2
@MaximilianoRicoTabo
Check that active gateway is stripe in order to show payment action r…
42941d7 
…equired email template in the email templates sub tab
@MaximilianoRicoTabo
* Remove remaining conflict chars
aacf1b8
@MaximilianoRicoTabo
* Deprecate sendBillableInvoiceEmail and call sendInvoiceEmail from t…
a1475c1 
…here
@MaximilianoRicoTabo
* Remove !!billing_url!! and do the same with !!login_url!! in paymen…
1c03b2d 
…t failure email
@MaximilianoRicoTabo
* Restore default template to $pmpro_email_templates_defaults.
179f110 
* Hide it in the adming pages behind a filter.
@MaximilianoRicoTabo MaximilianoRicoTabo force-pushed the enhancement/overhaul-email-templates branch from 7f14dfa to 179f110 Compare July 1, 2024 12:47
@MaximilianoRicoTabo MaximilianoRicoTabo force-pushed the enhancement/overhaul-email-templates branch from 4659b73 to 5ea8d4d Compare July 1, 2024 14:50
@dparker1005 dparker1005 added this to the 3.1 milestone Jul 1, 2024
@MaximilianoRicoTabo MaximilianoRicoTabo marked this pull request as ready for review July 2, 2024 15:23
@dparker1005 dparker1005 merged commit 5f5f07d into strangerstudios:v3.1 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dparker1005 dparker1005 Awaiting requested review from dparker1005

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaximilianoRicoTabo @dparker1005