Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed slashes in From Name setting. #3050

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

andrewlimaza
Copy link
Contributor

  • BUG FIX: Fixed an issue where the From Name email setting would escape apostrophe's but not remove the slash on the frontend (settings and email received).

Also WPCS was applied to the pmpro_wp_mail_from_name function.

All Submissions:

How to test the changes in this Pull Request:

  1. Set the from name to something like: PMPro's Test Site and save your settings. You will see it changes PMPro\'s Test Site
  2. After pulling this PR, it should set the values back to PMPro's Test Site on the settings page as well as the From name within the email browser.

* BUG FIX: Fixed an issue where the from name would escape and output `\'s` when using apostrophes. This improves the output now to unslash the string when outputting.
@dparker1005 dparker1005 added this to the 3.1 milestone Jul 11, 2024
@dparker1005 dparker1005 merged commit 4de81ef into strangerstudios:v3.1 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants