Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display issue on iPhone where password field and toggle were over… #3078

Merged

Conversation

kimcoleman
Copy link
Member

…lapping other fields

All Submissions:

Changes proposed in this Pull Request:

Fixes display issue where password field would overlap others in the Account Information section on Membership Checkout only when the "confirm" field was also shown. This appeared to only be happening on iOS mobile devices.

Screenshot 2024-07-22 at 10 50 07 AM
Before fix - overlap

Screenshot 2024-07-22 at 10 49 58 AM
With fix - no overlap

In tests, this was not an issue on the regular password login / reset fields OR on the logged in profile edit > change password view.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@dparker1005 dparker1005 merged commit 2963c26 into strangerstudios:dev Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants