Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure echoing when escaping attributes #3080

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

mircobabini
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Resolves the issue we had about required field not filled in in checkout without additional warning.
This is because when not using international addresses, the default country is not written into the hidden field.

How to test the changes in this Pull Request:

  1. Deactivate international addresses (via filter)
  2. Then see the checkout working again

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@dparker1005 dparker1005 merged commit 3c745a3 into strangerstudios:dev Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants