Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pmpro_membership_level] shortcode #3087

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

kimcoleman
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Creates a new pmpro_membership_level shortcode to display individual parts of a Membership Level (for Page Builders and custom-crafting a Membership Levels / Pricing page.

Screenshot 2024-07-26 at 7 49 35 AM
Screenshot 2024-07-26 at 7 50 34 AM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

  • FEATURE: Added new pmpro_membership_level shortcode to pull in dynamic information about a specific level ID.

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005
Copy link
Member

Looks good! A couple thoughts:

  • Do we need to strip this shortcode from posts if the editor doesn't have the edit_users capability? With user meta, there could be sensitive data there that we don't want to get out. But are these level settings sensitive?

  • In other places in the code, we override the "confirmation" message to be an empty string if the current user doesn't have the corresponding membership level. We should consider doing that here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants