Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change submit url to target the specific member panel, to keep the URL consistent #3092

Merged

Conversation

mircobabini
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Before this fix, when you change a Level manually, after saving you going to see that:

  • You are still on the Member > Membership tab (because of the hidden field pmpro_member_edit_panel)
  • The URL does NOT contain the pmpro_member_edit_panel anymore
  • Refreshing the page will bring you away from the Member > Membership panel obviously

Moving the pmpro_member_edit_panel directive from the hidden field to the submit action will make the URL consistent after saving.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@mircobabini
Copy link
Member Author

We have a similar behavior after saving a level in Settings > Levels. Slightly different, but similar.

@dparker1005 dparker1005 merged commit 6697566 into strangerstudios:dev Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants