Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin notice when Stripe webhooks are not set up #3103

Merged

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

With Stripe Checkout becoming default, we are hearing more reports of issues caused by webhooks not being set up. We currently automatically set up webhooks when a site connects to Stripe, but this misses cases when legacy API keys are used or when a staging site connects to Stripe and the setup is then migrated to a live site on a different domain.

This PR shows an admin notice when the Stripe gateway is being used and webhooks are not set up on the website.
Screenshot 2024-08-01 at 11 47 13 AM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Copy link
Member

@kimcoleman kimcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted language slightly but good to go. David is gonna look into why there is sometimes a disabled create webhook button.

@kimcoleman kimcoleman removed the request for review from kimwhite August 2, 2024 15:58
@dparker1005 dparker1005 merged commit 0ffcd92 into strangerstudios:dev Aug 2, 2024
@dparker1005 dparker1005 deleted the stripe-webhook-admin-notice branch August 2, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants