fix: do not add drift-loading class after first hover #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prettier is always trying to up its commit count 👏 |
jayeb
approved these changes
Aug 30, 2019
…ft into properly-remove-loading-safari
jayeb
approved these changes
Sep 6, 2019
sherwinski
force-pushed
the
properly-remove-loading-safari
branch
from
2082ec2
to
0644bf3
Compare
sherwinski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #236, addressing unexpected behavior caused by webkit not firing a
loadevent when an img src is set without actually changing it. This causes a loading animation to appear even if the image has apparently loaded successfully, as this animation is only removed once the expectedloadevent is triggered.This PR prevents this scenario by avoiding these steps after the first image load.