refactor(dht): Do not store ConnectionType
#2049
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teogeb
changed the title
ConnectionTypeConnectionType
teogeb
force-pushed
the
rm-connection-type
branch
from
4b10d02
to
06a11ad
Compare
teogeb
force-pushed
the
rm-connection-type
branch
from
06a11ad
to
0ed9282
Compare
harbu
reviewed
Nov 23, 2023
| @@ -362,7 +362,7 @@ export class ConnectionManager extends EventEmitter<TransportEvents> implements | |||
| private onConnected(connection: ManagedConnection) { | |||
| const peerDescriptor = connection.getPeerDescriptor()! | |||
| this.emit('connected', peerDescriptor) | |||
| logger.trace(getNodeIdFromPeerDescriptor(peerDescriptor) + ' onConnected() ' + connection.connectionType) | |||
| logger.trace(getNodeIdFromPeerDescriptor(peerDescriptor) + ' onConnected()') | |||
There was a problem hiding this comment.
I would keep the connectionType in the logging statements when it is relevant.
Comment on lines
73
to
74
| expect((node1.getTransport() as ConnectionManager).getConnection(node2.getLocalPeerDescriptor())!.connectionType) | ||
| .toEqual(ConnectionType.WEBRTC) | ||
| expect((node2.getTransport() as ConnectionManager).getConnection(node1.getLocalPeerDescriptor())!.connectionType) |
There was a problem hiding this comment.
These assertions related to connectionType are important to validate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to store a
connectionTypevalue for eachManagedConnectioninstance as the information can be queried by calling theexpectedConnectionTypehelper function. The helper was introduced in #2043.Removed obsolete
ConnectionType#SIMULATOR_*enum values.Future improvements
ConnectionTypecould be string literals instead of enum values as we prefer those nowadays.