[cspell-types] Interfaces *Source incorrectly extends interface BaseSource

[david-bojnansky]

Info

Kind of Issue

• runtime - command-line tools
• building / compiling
• security
• change in behavior
• crash / error

Which Tool or library

• cspell -- the command-line spelling tool
• cspell-tools -- used for building dictionary files
• cspell-lib -- library that does the actual spell checking.
• cspell-trie -- tool for working with trie files.

Which Version

Version: 5.13.0

Issue with supporting library?

• No
• cspell-glob -- library for matching glob patterns
• cspell-io -- thin file i/o library
• cspell-trie-lib - trie lib
• cspell-trie2-lib - trie lib alternate format
• cspell-types

OS:

• Macos
• Linux
• Windows
• Other

Bug Description

Describe the bug

Interfaces *Source incorrectly extends interface BaseSource.

Possible Solution

If possible, remove extends BaseSource as below.

or

add before each problematic interface // @ts-expect-error TS2430.

Screenshots

extends BaseSource causes an error:

without extends BaseSource:

[Jason3S]

@david-bojnansky,

Thank you. I'll take a look.

[Jason3S]

@david-bojnansky,

I'm not able to reproduce this. Do you have a sample repo with the problem?

What version of Typescript are you using?

Kind regards,
Jason

[david-bojnansky]

@Jason3S,

I just install the @cspell/cspell-types as (dev-)dependency and in my one .d.ts file I do import type { FileSettings } from '@cspell/cspell-types'. TypeScript checks also your .d.ts (though it is in node_modules/) and finds the errors. I could set skipLibCheck to true in my tsconfig.json but it also stops to check all my local .d.ts files and that's unwanted for me.

Yeah, I got what the problem is. I cloned your repository and add "exactOptionalPropertyTypes": true to tsconfig.json (because in my tsconfig.json it is there) and the errors raise up.

TypeScript: 4.5.2

[Jason3S]

Yeah, I got what the problem is. I cloned your repository and add "exactOptionalPropertyTypes": true to tsconfig.json (because in my tsconfig.json it is there) and the errors raise up.

"exactOptionalPropertyTypes": true - That is it! Thank you.

Hmm, I need to find a workaround for that. I'm not sure if it is possible. That is the whole point of extending the base is to turn an optional property into a required one.

[david-bojnansky]

Thanks.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.