fix: fix bug for check unsafe.Pointer isNil (#1319)

stretchr · Dec 20, 2022 · 9acc222 · 9acc222
1 parent 1333b5d
commit 9acc222
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/assert/assertions.go b/assert/assertions.go
@@ -530,7 +530,7 @@ func isNil(object interface{}) bool {
 		[]reflect.Kind{
 			reflect.Chan, reflect.Func,
 			reflect.Interface, reflect.Map,
-			reflect.Ptr, reflect.Slice},
+			reflect.Ptr, reflect.Slice, reflect.UnsafePointer},
 		kind)
 
 	if isNilableKind && value.IsNil() {

diff --git a/assert/assertions_test.go b/assert/assertions_test.go
@@ -15,6 +15,7 @@ import (
 	"strings"
 	"testing"
 	"time"
+	"unsafe"
 )
 
 var (
@@ -2558,3 +2559,10 @@ func TestErrorAs(t *testing.T) {
 		})
 	}
 }
+
+func TestIsNil(t *testing.T) {
+	var n unsafe.Pointer = nil
+	if !isNil(n) {
+		t.Fatal("fail")
+	}
+}