Suppress type errors from latest pyright #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have some tests that exercise these parameters? |
|
Turns out this is actually not safe. We don't use the little '*' trick to prevent keyword args from being passed positionally, so we have to suppress the type errors until we can do a major. |
richardm-stripe
force-pushed
the
richardm-unpin-pyright
branch
from
706b0b8
to
0758b55
Compare
richardm-stripe
changed the title
pakrym-stripe
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit-by-commit.
For Fix redundant keyword params -- I checked that this was safe by looking into the implementation of
_static_requestor_requestin each case and observing thatutil.read_special_variablewas called (eventually) to grab the value from `params.