Run pyright via tox #1134
Merged
Run pyright via tox #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age set to editable-legacy under testenv:pyright section.
richardm-stripe
approved these changes
Nov 15, 2023
…pyright == 1.1.336' from test-requirements.
…version for set up, add new set up for Python 3.10 after pip cache settings.
pakrym-stripe
commented
Nov 15, 2023
pakrym-stripe
commented
Nov 15, 2023
… typechecking step with pyright.
pakrym-stripe
commented
Nov 15, 2023
pakrym-stripe
commented
Nov 15, 2023
pakrym-stripe
commented
Nov 15, 2023
pakrym-stripe
commented
Nov 15, 2023
pakrym-stripe
commented
Nov 15, 2023
…testenv in tox.ini.
…"Typecheck and lint" to "Lint", remove the "Typecheck with pyright" step from the lint job, add a new "Typecheck with pyright" step to the jobs with command line arguments, and rearrange the order of the steps.
…", specifically in the command for the "Typecheck with pyright" action.
…ss positional arguments in pyright command in tox.ini.
…d 'test' target to depend on 'lint', and changed 'PYTHON' variable in 'test' target to 'DEFAULT_TEST_ENV'.
…ersions to environments explicitly and replace variable 'python-version' with 'env' in the command run by tox.
…the existing Python setup in ci.yml, and removed tox-gh-actions from requirements.txt.
pakrym-stripe
commented
Nov 15, 2023
…to dropped support for Python versions <= 3.6, and remove Python 3.6 basepython specification from tox.ini file.
…sion constraint for virtualenv in requirements.txt.
richardm-stripe
approved these changes
Nov 15, 2023
…cated cryptography support for Python 3.6 and PyPy3 < 7.3.10 in requirements.txt, and added comments for requirements and test-requirements.
… in .github/workflows/ci.yml.
…e 'python-version' to 'python.version', significantly simplify matrix configuration, and adjust related environment variables.
…/workflows/ci.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our infrastructure to always run tools on python3.10 and only run tests on different versions of python.