Add initial tests for exports and run them in mypy and pyright #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peline, updated formatting and removed type ignores in multiple files, added mypy configuration in pyproject.toml, and updated tests for typing.
… long lines across several files in the Stripe API library.
…__` method of the `ListObject` class in the file `stripe/api_resources/list_object.py` has been simplified from multiple lines to a single line.
pakrym-stripe
commented
Nov 16, 2023
| exclude = ["build", "**/__pycache__"] | ||
| reportMissingTypeArgument = true | ||
| reportUnnecessaryCast = true | ||
| reportUnnecessaryComparison = true | ||
| reportUnnecessaryContains = true | ||
| reportUnnecessaryIsInstance = true | ||
| reportPrivateImportUsage = true | ||
| reportUnnecessaryTypeIgnoreComment = true |
There was a problem hiding this comment.
We might need to use #type: ignore in import tests for negative cases.
…tipart_data_generator.py, and stripe_object.py.
pakrym-stripe
commented
Nov 16, 2023
pakrym-stripe
commented
Nov 16, 2023
…_exports.py for better readability.
richardm-stripe
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.