-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor integration test #1145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why these tests need an actual HTTP server and can't be done on top of HTTP client mock.
Some of the logic being tested here is logic that is implemented in |
* Refactor integration test * Update tests/test_integration.py
tests/test_integration.py is a test file that spins up an HTTP server running in a separate thread and is useful for tests that need to be written at the HTTP level, but I ran into some difficulties when attempting to add a new test here. This PR refactors the test helper a bit to make it more usable:
Queue
and you can assert on the received requests inside the test.TestServer
and (optionally) implementdo_request(n: int)
to return [status_code, headers, body]`