Beta: codegenned async methods on resources #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-async-codegen
branch
from
ac534f1
to
ce9d102
Compare
richardm-stripe
requested review from
a team and
helenye-stripe
and removed request for
a team
richardm-stripe
force-pushed
the
richardm-async-codegen
branch
from
ce9d102
to
b5a5f96
Compare
anniel-stripe
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
No .request_stream_async yet. Needed for completeness, but can happen in a follow-up.
I saw request_stream_async was added in #1219 to APIRequestor / StripeObject, why are we omitting it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Includes #1219 - review that first for non-codegenned portion.
Adds (codegenned)
_asyncmirrors for resource methods. (See codegen)Adds
_asyncmirrors for certain infrastructure methods. (See [add more infra)Notes
.request_stream_asyncyet. Needed for completeness, but can happen in a follow-up.Testing
Generated tests