-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta: async streaming #1233
Merged
Merged
Beta: async streaming #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
commented
Feb 13, 2024
anniel-stripe
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a few nits / questions but nothing blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provides an implementation for
request_stream_async
forHTTPClientAsync
, so e.g.await stripe.Quote.pdf_async(...)
will work.Details
stripe.Quote.pdf_async
). The difference from StripeStreamResponse is that the stream is represented bystream: AsyncIterable[bytes]
instead ofio: IOBase
.IOBase
implementsIterable[bytes]
-- so there's more symmetry betweenStripeStreamResponse
andStripeResponse
than appears at first glance.HTTPClientAsync.request_stream_async
is nowTuple[AsyncIterable[bytes], ...]
and an implementation is provided for HTTPXHttpClient.I was worried about a resource leak -- inside HTTPXHttpClient it calls
response = httpx.ASyncClient().send(...)
and then takescontent = response.aiter_bytes()
and only returnscontent
to the caller. Doesresponse
get closed properly? I manually tested, and yes, after you do anasync for
through the bytes incontent
the response gets closed automatically.