Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta: add AIOHTTP http client #1254

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Beta: add AIOHTTP http client #1254

merged 7 commits into from
Feb 27, 2024

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Feb 24, 2024

Like it says on the tin.
Things to note: aiohttp only supports asyncio, not trio. Otherwise this is not too different from the HTTPXClient logic.

@richardm-stripe richardm-stripe requested review from a team and pakrym-stripe and removed request for a team February 27, 2024 00:57
Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions.

@richardm-stripe
Copy link
Contributor Author

All feedback has a response

@richardm-stripe richardm-stripe merged commit eaa54a3 into beta Feb 27, 2024
15 checks passed
@xavdid-stripe xavdid-stripe deleted the richardm-aiohttp-client branch May 10, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants