Port async support from beta to the stable channel #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support AIOHTTPClient init without running event loop Lazily instantiates and caches an aiohttp `ClientSession` at the points that it is actually used so that `AIOHTTPClient` can be initialized without a running event loop (e.g. when setting `stripe.default_http_client = stripe.AIOHTTPClient()` at the top level of a module). * Format * Assert aiohttp module is present in AIOHTTPClient Fixes a type checking error by having `AIOHTTPClient`'s `_session` property assert that the `aiohttp` module exists * Remove dependence on cached_property The `functools.cached_property` decorator did not exist in Python 3.7, so `AIOHTTPClient`'s `_session` has been changed into a regular property that performs caching manually by storing the `ClientSession` object as a member of the instance. * Define aiohttp cached session attribute in init Ensures `AIOHTTPClient`'s `_cached_session` attribute is defined in the initializer.
richardm-stripe
force-pushed
the
richardm-ga-async-2
branch
from
c2cd984
to
abc6441
Compare
richardm-stripe
requested review from
a team and
pakrym-stripe
and removed request for
a team
|
cc @pakrym-stripe want to continue to talk through StripeStreamResponseAsync to see if my thoughts are reasonable |
pakrym-stripe
approved these changes
Apr 3, 2024
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created via
git checkout -p beta <files that weren't codegenned>and some judicious manual cleaning up. I cherry-picked the PRs from outside collaborators for attribution reasons.