don't auto-organize imports #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid-stripe
requested review from
a team and
prathmesh-stripe
and removed request for
a team
prathmesh-stripe
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor VSCode settings tweak to reduce noise in PRs.
I like auto-formatted imports, but our imports are not currently sorted (as far as VSCode is concerned). I was finding that auto-sorting added a lot of noise to PRs when I was working in unsorted files. Plus, this is a VS-code specific operation, so if team members use a different editor, imports would be unsorted until a VSCode user happened to work on the same file.
A better solution would ruff to handle the import sorting, which all editors (and tooling) will pick up and help us maintain. But that's slightly more involved, so short term I figured disabling the behavior was simpler.
If you want to sort imports manually, you can still run VSCode's Organize Imports command.