Add support for providing custom CA cert bundle #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! LGTM. (And thanks for following the same naming convention as Stripe Ruby for It looks like the PyPi build is having trouble, and I don't understand it exactly.: File "/home/travis/virtualenv/pypy3.5-5.8.0/site-packages/pipenv/_compat.py", line 66, in force_encoding
from ctypes import pythonapi, py_object, c_char_p
ImportError: cannot import name 'pythonapi'
make: *** [init] Error 1I restarted it, but it doesn't appear to be a transient problem because it failed again. Mind taking a look? ptal @ob-stripe |
|
@brandur-stripe It's a problem with pipenv itself. I submitted a fix (pypa/pipenv#3322) but they haven't released a new version yet. |
|
Released as 2.15.0. |
|
Ah, I see! And wow — nice work on that pipenv patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Add support for providing a custom CA bundle, by setting
stripe.ca_bundle_path.Fixes #501.
It's kind of difficult to write automated tests for this, but I've manually tested that this works with both
RequestsClientandPycurlClient.While I was at it, I also updated the embedded bundle to the latest version from https://curl.haxx.se/docs/caextract.html.