Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix del statement to not raise KeyError #599

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Fix del statement to not raise KeyError #599

merged 1 commit into from
Aug 6, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

Fixes #596.

@rattrayalex-stripe
Copy link
Contributor

LGTM

@ob-stripe ob-stripe assigned ob-stripe and unassigned brandur-stripe Aug 6, 2019
brandur-stripe
brandur-stripe approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test! LGTM too.

@ob-stripe ob-stripe merged commit 2a20652 into master Aug 6, 2019
@ob-stripe ob-stripe deleted the ob-fix-del branch August 6, 2019 17:29
@ob-stripe
Copy link
Contributor Author

Released as 2.33.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandur-stripe brandur-stripe brandur-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

del StripeOject.metadata['some_key'] deletes key AND raises KeyError
3 participants
@ob-stripe @rattrayalex-stripe @brandur-stripe