Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin click dependency to 8.0.4 to avoid breakage in black #784

Merged
merged 4 commits into from
Mar 28, 2022

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Mar 28, 2022

The new version of https://pypi.org/project/click/#history package broke the code formatter we use. Pin to a known good version.

@pakrym-stripe pakrym-stripe changed the title See if master builds Fix master build Mar 28, 2022
@pakrym-stripe pakrym-stripe marked this pull request as ready for review March 28, 2022 21:53
Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PR title will show up in the changelog, so let's change the title to be more descriptive. Maybe "Pin click dependency to 8.0.4 to avoid breakage in black"?

@pakrym-stripe pakrym-stripe changed the title Fix master build Pin click dependency to 8.0.4 to avoid breakage in black Mar 28, 2022
@pakrym-stripe pakrym-stripe merged commit 8a45c2b into master Mar 28, 2022
@remi-stripe remi-stripe deleted the pakrym/See_if_master_builds branch September 28, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants