API Updates #794
Merged
API Updates #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
suggested changes
Apr 18, 2022
stripe/object_classes.py
Outdated
| @@ -39,7 +39,6 @@ | |||
| api_resources.File.OBJECT_NAME: api_resources.File, | |||
| api_resources.File.OBJECT_NAME_ALT: api_resources.File, | |||
| api_resources.FileLink.OBJECT_NAME: api_resources.FileLink, | |||
| api_resources.FundingInstructions.OBJECT_NAME: api_resources.FundingInstructions, | |||
There was a problem hiding this comment.
We need to keep this line
stripe/api_resources/customer.py
Outdated
| def create_funding_instructions(self, idempotency_key=None, **params): | ||
| url = self.instance_url() + "/funding_instructions" | ||
| headers = util.populate_headers(idempotency_key) | ||
| self.refresh_from(self.request("post", url, params, headers)) |
There was a problem hiding this comment.
This shouldn't refresh_from and instead return the funding instructions
kamil-stripe
approved these changes
Apr 18, 2022
| self.resource.request("post", url, params, headers) | ||
| ) | ||
| return self.resource | ||
| resp = self.resource.request("post", url, params, headers) |
There was a problem hiding this comment.
This might be a breaking change, we are not refreshing the original resource anymore..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contains corrections to #792 which was merged but not released.
We are not releasing
GET /v1/customers/:id/funding_instructionsyet and are releasing only thePOST, and are generating it as a "custom method" instead of the nested resource method.