Unify request sending and result parsing logic #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng_and_result_parsing_logic
…ng_and_result_parsing_logic # Conflicts: # stripe/api_resources/account.py # stripe/api_resources/apps/secret.py # stripe/api_resources/charge.py # stripe/api_resources/checkout/session.py # stripe/api_resources/credit_note.py # stripe/api_resources/customer.py # stripe/api_resources/dispute.py # stripe/api_resources/financial_connections/account.py # stripe/api_resources/identity/verification_session.py # stripe/api_resources/invoice.py # stripe/api_resources/issuing/authorization.py # stripe/api_resources/issuing/card.py # stripe/api_resources/issuing/dispute.py # stripe/api_resources/order.py # stripe/api_resources/payment_intent.py # stripe/api_resources/payment_link.py # stripe/api_resources/payment_method.py # stripe/api_resources/payout.py # stripe/api_resources/quote.py # stripe/api_resources/refund.py # stripe/api_resources/review.py # stripe/api_resources/setup_intent.py # stripe/api_resources/subscription_schedule.py # stripe/api_resources/terminal/reader.py # stripe/api_resources/test_helpers/test_clock.py # stripe/api_resources/topup.py # stripe/api_resources/transfer.py # stripe/api_resources/treasury/financial_account.py # stripe/api_resources/treasury/inbound_transfer.py # stripe/api_resources/treasury/outbound_payment.py # stripe/api_resources/treasury/outbound_transfer.py # stripe/api_resources/treasury/received_credit.py # stripe/api_resources/treasury/received_debit.py # tests/test_generated_examples.py
pakrym-stripe
changed the title
|
r? @dcr-stripe |
dcr-stripe
approved these changes
Jul 12, 2022
Comment on lines
+242
to
+243
| method_, | ||
| url_, |
There was a problem hiding this comment.
Nit: Why the _ suffix here?
There was a problem hiding this comment.
Ah just saw https://github.com/stripe/stripe-python/pull/832/files#diff-4656b48a9a21bc574de7c8bfb7e0aaa00241eb172da79110b30d6615685b64f3R101-R102 - can we carry over that comment here + in api_resource so we don't accidentally remove it?
|
Removed some outdated tests for APIs that were removed from the next major. r? @dcr-stripe |
dcr-stripe
reviewed
Jul 12, 2022
dcr-stripe
reviewed
Jul 12, 2022
…ng_and_result_parsing_logic # Conflicts: # stripe/api_resources/checkout/session.py # stripe/api_resources/credit_note.py # stripe/api_resources/invoice.py # stripe/api_resources/source.py
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Aug 19, 2022
4.0.2 - 2022-08-03 * Fix issue where auto_paging_iter failed on nested list objects. 4.0.1 - 2022-08-02 * Fix incorrect handling of additional request parameters * Fixes issue where using special parameter like `api_key`, `idempotency_key`, `stripe_version`, `stripe_account`, `headers` can cause a `Received unknown parameter error`. 4.0.0 - 2022-08-02 Breaking changes that arose during code generation of the library that we postponed for the next major version. For changes to the SDK, read more detailed description at https://github.com/stripe/stripe-python/wiki/Migration-guide-for-v4. For changes to the Stripe products, read more at https://stripe.com/docs/upgrades#2022-08-01. "⚠️ " symbol highlights breaking changes. * API Updates * Next major release changes * API Updates. Add Price.create tests. * API Updates. Use auto-generation for credit_note and invoice methods.⚠️ Removed - Removed deprecated `AlipayAccount`, `BitcoinReceiver`, `BitcoinTransaction`, `IssuerFraudRecord`, `Recipient`, `RecipientTransfer`, and `ThreeDSecure` classes. - Removed deprecated `Charge.update_dispute` and `Charge.close_dispute` methods that were using legacy REST API endpoint. Prefer [Dispute.modify](https://stripe.com/docs/api/disputes/update?lang=python) and [Dispute.close](https://stripe.com/docs/api/disputes/close?lang=python) - Removed deprecated `Card.details` method and `CardDetails` resource. The REST API endpoint is not longer supported. - Removed the deprecated `Source.source_transactions` method. Prefer `SubscriptionItem.list_source_transactions` - Removed the deprecated `SubscriptionItem.usage_record_summaries` method. Prefer `SubscriptionItem.list_usage_record_summaries` - Removed the deprecated `Charge.refund` method. Prefer [Refund.create](https://stripe.com/docs/api/refunds/create)⚠️ Changed - To be consistent with other resource methods, `ApplicationFee.refund` returns an instance of `ApplicationFee` and doesn't mutate the instance of `ApplicationFee`. - To be consistent with other resource methods, the `Customer.delete_discount` no longer resets the `discount` property to `None` and returns the deleted discount instead. If you were relying on this behavior, reset the discount property manually: - The `LineItem` resource now inherits from `StripeObject` as it has no methods of it's own. - To be consistent with other resource methods, the `Subscription.delete_discount` returns an instance of deleted discount and doesn't mutate the instance of `Subscription`. - Update the CA certificate bundle. - Request sending logic unified across standard and custom methods (stripe/stripe-python#832)
remi-stripe
deleted the
pakrym/Unify_request_sending_and_result_parsing_logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify request sending logic into a single method and call it from all the places we make requests from.