-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next major release changes #895
Conversation
Update supported runtime versions
Generate files for next major branch
Remove SKU resource
* Add deprecation message and update NotImplementedError in modify() * Update deprecation message * Change to deprecation warning * Revert back to docstring
Bring next major branch up to date with master
Feedback for the changelog entries
But we didnt really "remove" it. We only deprecated it...
To avoid any misunderstanding that everything below 3.5 is also dropped, lets change this to We need an entry for the error name typo fix - UnsupportedResponseTypError -> UnsupportedResponseTypeError and the other one with it |
Thanks for reviewing, Ramya! Just updated the Changelog with your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog looks good!
Only thought was around the renamed error- might be worth adding a blurb like
if you were catching the incorrectly-named
UnsupportedResponseTypError
in your code, make sure to update yourexcept
statements withUnsupportedResponseTypeError
instead.
Though IIRC, the typo error didn't exist, so it wouldn't have ever been thrown in the first place and there won't be user code depending on it. That could also be worth mentioning.
Update sdk-release/next-major with latest API changes
Changelog
5.0.0 - 2022-11-15
Breaking changes that arose during code generation of the library that we postponed for the next major version. For changes to the Stripe products, read more at https://stripe.com/docs/upgrades#2022-11-15.
"⚠️ " symbol highlights breaking changes.
UnsupportedGrantTypError
->UnsupportedGrantTypeError
andUnsupportedResponseTypError
->UnsupportedResponseTypeError
(Corrected mistyped OAuth exceptions #872).Deprecated
save
method on resources (Deprecate save() #887). Usemodify
instead.Orders
resource (Generate files for next major branch #882).SKU
resource (Remove SKU resource #883).