Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next major release changes #895

Merged
merged 16 commits into from
Nov 16, 2022
Merged

Next major release changes #895

merged 16 commits into from
Nov 16, 2022

Conversation

anniel-stripe
Copy link
Contributor

@anniel-stripe anniel-stripe commented Nov 4, 2022

Changelog

5.0.0 - 2022-11-15

Breaking changes that arose during code generation of the library that we postponed for the next major version. For changes to the Stripe products, read more at https://stripe.com/docs/upgrades#2022-11-15.

"⚠️" symbol highlights breaking changes.

⚠️ Changed

Deprecated

⚠️ Removed

@ramya-stripe
Copy link
Contributor

Feedback for the changelog entries

Removed deprecated save method on resources. Use modify instead

But we didnt really "remove" it. We only deprecated it...

Dropped support for Python version 3.5.

To avoid any misunderstanding that everything below 3.5 is also dropped, lets change this to Dropped support for Python version 3.4 and 3.5. We now support Python 2.7 or 3.6+.

We need an entry for the error name typo fix - UnsupportedResponseTypError -> UnsupportedResponseTypeError and the other one with it

@anniel-stripe
Copy link
Contributor Author

Thanks for reviewing, Ramya! Just updated the Changelog with your feedback.

Copy link
Member

@xavdid-stripe xavdid-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks good!

Only thought was around the renamed error- might be worth adding a blurb like

if you were catching the incorrectly-named UnsupportedResponseTypError in your code, make sure to update your except statements with UnsupportedResponseTypeError instead.

Though IIRC, the typo error didn't exist, so it wouldn't have ever been thrown in the first place and there won't be user code depending on it. That could also be worth mentioning.

@anniel-stripe anniel-stripe merged commit f35106d into master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants