Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in custom constraint parser, minor improvements #40

Merged
merged 24 commits into from
Mar 23, 2019
Merged

Fix bug in custom constraint parser, minor improvements #40

merged 24 commits into from
Mar 23, 2019

Conversation

prateekkumarweb
Copy link
Collaborator

@prateekkumarweb prateekkumarweb commented Nov 9, 2018 •
edited
Loading

  1. coreInMorningTime: Unbundled.
  2. electiveInNonMorningTime: Unbundled.
  3. Variables in custom parser can have < and >.
  4. Fix a bug in the unbundled custom constraint.
  5. CSV Input: Parse Y as Yes and N, as No.
  6. Display the course name of the failed custom constraint.
  7. Build: Do not build tests/tools/contrib in yaml-cpp.
  8. Snap: Fix issue when accessing files.
  9. minorInMinorTime: Unbundled.
  10. programAtMostOneOfCoreOrElective: Unbundled.
  11. exactlyOneFieldValuePerCourse: Unbundled.
  12. Wrap custom constraints grammar in a namespace and include that in doxygen.
  13. Fix bug caused due to MinorType being enum.
  14. CSV Input: Parse C, Y as Core; E as Elective; N, as No.
  15. Generate version numbers from a custom script gen_version.sh.

@prateekkumarweb
Fix bug, minor improvements
b641830 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb prateekkumarweb added this to the v0.4.0 milestone Nov 9, 2018
@prateekkumarweb prateekkumarweb changed the title Fix bug, minor improvements Fix bug in custom constraint parser, minor improvements Nov 9, 2018
sukrutrao
sukrutrao reviewed Nov 10, 2018
View reviewed changes
Copy link
Owner

@sukrutrao sukrutrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating of customMap and resetting of member values in obj might have to be done here as well.

@prateekkumarweb
Copy link
Collaborator Author

@GoodDeeds It had to done in constraint_expr. I have done it.

@prateekkumarweb
yaml-cpp: Do not build unnecessary tools
c863bb7 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
snap: Fix issue with accessing home folder
402552b 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
snap: Fix deprecated warning
c9c1f13 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
constraint_adder: unbundle some of the predefined constraints
d7cd72a 
minorInMinorTime
programAtMostOneOfCoreOrElective
exactlyOneFieldValuePerCourse

Signed-off-by: Prateek Kumar <[email protected]>
@sukrutrao
Copy link
Owner

@prateekkumarweb Unbundling will require a few other changes as well. I will do it.

@prateekkumarweb
Wrap custom parser grammar in namespace
f2d3859 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
doxygen: generate docs for custom constraint grammar
e226f3f 
Now the class list will not be cluttered in doxygen as all
the relevant classes for custom constraint grammar are
put in a namespace

Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
doxygen: Add documentation of some of the undocumented functions
fdc5d46 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
Predefined Constraint: Add high level vars for each course
5737962 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
cmake: Add -Wpedantic flag
c8b1d77 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
Change MinorType to enum class (also fixes isMinor bug)
2885211 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
Parser: CSV Parser program Core/Elective/No
2fec7b7 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
Generate version number from git
86478f6 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
Run gen_version.sh inside cmake
9c552fe 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
gen_version.sh: Disable print of version
6440035 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
snap: Fix version number in snap
045526a 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
install_dependencies.sh: Update folder names to not contain version
8321fde 
Signed-off-by: Prateek Kumar <[email protected]>
@prateekkumarweb
snap: Speed up dependency installation, fix version
0843e50 
Signed-off-by: Prateek Kumar <[email protected]>
@sukrutrao sukrutrao mentioned this pull request Dec 13, 2018
Open
@sukrutrao sukrutrao merged commit 0b807d5 into master Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukrutrao sukrutrao sukrutrao approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prateekkumarweb @sukrutrao